[mono][aot] Enabling AOT wrappers for virtual delegates - #85643
Merged
Conversation
added 5 commits
April 26, 2023 20:31
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
LeVladIonescu
added
the
NO-MERGE
LeVladIonescu
requested review from
SamMonoRT,
lambdageek,
thaystg and
vargaz
as code owners
May 2, 2023 11:54
LeVladIonescu
commented
May 2, 2023
| MonoJumpInfoToken *ji; | ||
| guint8 *p = buf; | ||
|
|
||
| printf("NAME = %s\n", method->name); |
Contributor
Author
There was a problem hiding this comment.
unrelated change...only for debug reasons
vargaz
reviewed
May 9, 2023
vargaz
reviewed
May 9, 2023
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
LeVladIonescu
changed the title
LeVladIonescu
removed
the
NO-MERGE
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Contributor
Author
|
Ready to review / merge. |
Contributor
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@LeVladIonescu - as part of this PR consider enabling any disabled tests fixed by the changes. |
Contributor
Author
|
@SamMonoRT will check |
kotlarmilos
reviewed
May 16, 2023
kotlarmilos
reviewed
May 16, 2023
| shared_context = mono_class_get_generic_container (method->klass)->context; | ||
| inst = shared_context.class_inst; | ||
|
|
||
| args = g_new0 (MonoType*, inst->type_argc); |
Member
There was a problem hiding this comment.
Is the memory being deallocated correctly?
Contributor
Author
There was a problem hiding this comment.
No, it is not. I would suggest deallocating it after
runtime/src/mono/mono/metadata/metadata.c
Line 3399 in 175dae9
^ @vargaz
Contributor
There was a problem hiding this comment.
I can be freed, but the aot compiler is already leaking memory in a number of places, so its not that important.
…d indentation Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Contributor
Author
|
Current failures are known and seem unrelated: |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 18, 2023
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 21, 2023
Contributor
Author
|
Remaining failures are known and unrelated. |
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
This was referenced May 22, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding AOT wrappers for delegate invoke virtual.
Contributes to #83329.